[FIXED] Panic in ordered consumer #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `orderedConsumer.reset()`, `retryWithBackoff()` is returned from with `false, nil` in case the subscription is closed. In this case, `var cons Consumer` is still `nil`, and the code crashes in the attempt to cast it to a `pullConsumer` later on. Fix this by catching the `nil` case explicitly. Signed-off-by: Daniel Mack <daniel.mack@holoplot.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Jarema
approved these changes
Jul 30, 2024
| @@ -142,6 +145,9 @@ func (c *orderedConsumer) Consume(handler MessageHandler, opts ...PullConsumeOpt | |||
| select { | |||
| case <-c.doReset: | |||
| if err := c.reset(); err != nil { | |||
| if errors.Is(err, errOrderedConsumerClosed) { | |||
There was a problem hiding this comment.
The only case for errOrderedConsumerClosed is when its stopped, so there is no point to try resetting it again, right?
There was a problem hiding this comment.
Yes, there is no point. I used continue here because when the consumer is stopped we'll eventually end up in <-sub.done case where the actual cleanup is performed.
Merged
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <piotr@synadia.com> Co-authored-by: Daniel Mack <daniel@zonque.org>
piotrpio
added a commit
that referenced
this pull request
Aug 15, 2024
Signed-off-by: Piotr Piotrowski <piotr@synadia.com> Co-authored-by: Daniel Mack <daniel@zonque.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com